perf: save bandwidth on dead bodies, CopyToBodyQue#79
Conversation
|
I played ~30 matches with this, found no issues. I tested by looking at the dead bodies closely when the owner of the dead body respawns. They still do twitch sometimes, but this also happens on vanilla, i.e. I'm pretty sure that this doesn't have to do with this MR. |
|
How did you measure the reduced network data if I may ask? |
It's easy to test this with `set cl_shownet 2; set bot_pause 1` and a single bot. Below is the diff between vanilla and this commit. As you can see, the "new" delta is smaller, some fields (`angles`, etc) are omitted. ```diff 22: ec-#1 remove -24: ec-#64 pos.trBase[0]:392 pos.trBase[1]:1431 pos.trBase[2]:24 apos.trBase[1]:315 angles2[1]:1 еТуре:1 torsoAnim:1 legsAnim:1 groundEntityNum:1022 eFlags:1 clientNum:1 angles[1]:135 apos.trType:1 (340 bits) -45: END OF MESSAGE +24: ec-#67 pos.trBase[0]:392 pos.trBase[1]:1431 pos.trBase[2]:24 ароs.trBase[1]:315 еТуре:1 torsoAnim:3 legsAnim:3 groundEntityNum:1022 eFlags:1 clientNum:1 (275 bits) +41: END OF MESSAGE ```
c82d488 to
e1d1bf4
Compare
|
Oops, you're right. I wanted to clarify this, but forgor 💀 |
According to the output of I also initially wanted to go for minimizing changes, but then found this out. |
OK, I also double-checked that this is not just a logging error. With Baselines are initialized here. Only the entity number is set there. But regardless of what the baseline is, And one can look at just the message size. It's 45 vs 41. |
It's easy to test this with
set cl_shownet 2; set bot_pause 1and a single bot.
Below is the diff between vanilla and this commit.
As you can see, the "new" delta is smaller,
some fields (
angles, etc) are omitted.So far things seem alright.